Ticket #15938: unlocalize_maxLength.diff

django/contrib/admin/templates/admin/prepopulated_fields_js.html

@@ +1 @@
+{% load l10n %}
 <script type="text/javascript">
 (function($) {
     var field = null;
@@ -7 +8 @@
         id: '#{{ field.field.auto_id }}',
         dependency_ids: [],
         dependency_list: [],
-        maxLength: {{ field.field.field.max_length|default_if_none:"50" }}
+        maxLength: {{ field.field.field.max_length|default_if_none:"50"|unlocalize }}
     };
 
     {% for dependency in field.dependencies %}

tests/regressiontests/admin_views/models.py

@@ -539 +539 @@
     subtitle = models.CharField(max_length=100)
     subslug = models.SlugField()
 
+class PrePopulatedPostLargeSlug(models.Model):
+    """
+    Regression test for #15938: a large max_length for the slugfield must not
+    be localized in prepopulated_fields_js.html or it might end up breaking
+    the javascript (ie, using THOUSAND_SEPARATOR ends up with maxLength=1,000)
+    """
+    title = models.CharField(max_length=100)
+    published = models.BooleanField()
+    slug = models.SlugField(max_length=1000)
+
+class PrePopulatedPostLargeSlugAdmin(admin.ModelAdmin):
+    prepopulated_fields = {
+        'slug' : ('title',)
+    }
+
 class SubPostInline(admin.TabularInline):
     model = PrePopulatedSubPost
 
@@ -864 +879 @@
 admin.site.register(Question)
 admin.site.register(Answer)
 admin.site.register(PrePopulatedPost, PrePopulatedPostAdmin)
+admin.site.register(PrePopulatedPostLargeSlug, PrePopulatedPostLargeSlugAdmin)

tests/regressiontests/admin_views/tests.py

@@ -2614 +2614 @@
         self.assertNotContains(response, "field['dependency_ids'].push('#id_title');")
         self.assertNotContains(response, "id: '#id_prepopulatedsubpost_set-0-subslug',")
 
+    def test_prepopulated_maxlength_localized(self):
+        """
+        Regression test for #15938: if USE_THOUSAND_SEPARATOR is set, make sure
+        that maxLength (in the javascript) is rendered without separators.
+        """
+        self.old_USE_THOUSAND_SEPARATOR = settings.USE_THOUSAND_SEPARATOR
+        self.old_USE_L10N = settings.USE_L10N
+        settings.USE_THOUSAND_SEPARATOR = True
+        settings.USE_L10N = True
+        response = self.client.get('/test_admin/admin/admin_views/prepopulatedpostlargeslug/add/')
+        self.assertContains(response, "maxLength: 1000") # instead of 1,000
+
+
 class ReadonlyTest(TestCase):
     fixtures = ['admin-views-users.xml']