Ticket #13878: 02-formset-refactoring-cleaned-data-tests.2.diff

tests/regressiontests/forms/formsets.py

@@ -308 +308 @@
 
 If we fill a form with something and then we check the can_delete checkbox for
 that form, that form's errors should not make the entire formset invalid since
-it's going to be deleted.
+it's going to be deleted. Some forms are invalid so we cannot use cleaned_data.
 
 >>> class CheckForm(Form):
 ...    field = IntegerField(min_value=100)
@@ -328 +328 @@
 >>> formset = CheckFormSet(data, prefix='check')
 >>> formset.is_valid()
 True
+>>> [form.cleaned_data for form in formset.forms]
+Traceback (most recent call last):
+...
+AttributeError: 'CheckForm' object has no attribute 'cleaned_data'
 
 If we remove the deletion flag now we will have our validation back.
 
@@ -517 +521 @@
 [{'votes': 900, 'DELETE': True, 'ORDER': 2, 'choice': u'Fergie'}]
 
 Should be able to get ordered forms from a valid formset even if a
-deleted form would have been invalid.
+deleted form would have been invalid and without cleaned_data.
 
 >>> class Person(Form):
 ...     name = CharField()
@@ -529 +533 @@
 
 >>> p = PeopleForm(
 ...     {'form-0-name': u'', 'form-0-DELETE': u'on', # no name!
-...      'form-TOTAL_FORMS': 1, 'form-INITIAL_FORMS': 1,
-...      'form-MAX_NUM_FORMS': 1})
+...      'form-1-name': u'John Smith', 'form-1-DELETE': u'',
+...      'form-TOTAL_FORMS': 2, 'form-INITIAL_FORMS': 2,
+...      'form-MAX_NUM_FORMS': 2})
 
 >>> p.is_valid()
 True
->>> p.ordered_forms
-[]
+>>> for form in p.ordered_forms:
+...    print form.cleaned_data
+{'DELETE': False, 'name': u'John Smith', 'ORDER': None}
+>>> [form.cleaned_data for form in p.forms]
+Traceback (most recent call last):
+...
+AttributeError: 'Person' object has no attribute 'cleaned_data'
 
 # FormSet clean hook ##########################################################