Django

Code

Ticket #9771 (reopened)

Opened 1 year ago

Last modified 9 months ago

Wrong form action

Reported by: tutonien Assigned to: jacob
Milestone: Component: Documentation
Version: 1.0 Keywords: tutorial, form, post, action, absolute
Cc: Triage Stage: Accepted
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Hello,

There may be an improvement in the form of the fourth part of the tutorial.

The form sends the vote to /polls/123/vote/ (with 123 the poll id) but the form itself is in the detail page which URL is /polls/123/. Therefore, it would make more sense to use a relative URL instead of an absolute one. 

<form action="/polls/{{ poll.id }}/vote/" method="post">

This way, the poll app would be more "pluggable" because the polls directory does not need to be at the root of the server. 

<form action="vote/" method="post">

Thank you for your time and your good work.

Attachments

Change History

02/26/09 21:00:55 changed by jacob

  • needs_better_patch changed.
  • needs_docs changed.
  • stage changed from Unreviewed to Accepted.
  • needs_tests changed.
  • milestone set to 1.1.

04/02/09 13:44:29 changed by jacob

  • owner changed from nobody to jacob.
  • status changed from new to assigned.

04/03/09 13:30:55 changed by jacob

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [10371]) Fixed a whole bunch of small docs typos, errors, and ommissions.

Fixes #8358, #8396, #8724, #9043, #9128, #9247, #9267, #9267, #9375, #9409, #9414, #9416, #9446, #9454, #9464, #9503, #9518, #9533, #9657, #9658, #9683, #9733, #9771, #9835, #9836, #9837, #9897, #9906, #9912, #9945, #9986, #9992, #10055, #10084, #10091, #10145, #10245, #10257, #10309, #10358, #10359, #10424, #10426, #10508, #10531, #10551, #10635, #10637, #10656, #10658, #10690, #10699, #19528.

Thanks to all the respective authors of those tickets.

04/12/09 11:28:27 changed by kmtracey

Note this change broke the error path through the associated view. See #10801.

06/10/09 07:50:27 changed by russellm

  • status changed from closed to reopened.
  • resolution deleted.
  • milestone deleted.

(In [10973]) Fixed #10801 -- Reverted a portion of [10371]. Practicality beats purity in this case. Thanks to bruce@z2a.org for the report. Refs #9771.

Add/Change #9771 (Wrong form action)




Change Properties
Action