Django

Code

Ticket #9518 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

Wrong JSON snippet on fixture documentation

Reported by: claude@2xlibre.net Assigned to: jacob
Milestone: 1.1 Component: Documentation
Version: 1.0 Keywords:
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

On http://docs.djangoproject.com/en/dev/howto/initial-data, the JSON fixture example is wrong. Unlike Python, JSON doesn't allow commas after last element of a list or a dict.

The right example should be: 

[
  {
    "model": "myapp.person",
    "pk": 1,
    "fields": {
      "first_name": "John",
      "last_name": "Lennon"
    }
  },
  {
    "model": "myapp.person",
    "pk": 2,
    "fields": {
      "first_name": "Paul",
      "last_name": "McCartney"
    }
  }
]

Attachments

9518.diff (304 bytes) - added by ramiro on 04/02/09 12:48:10.
Trivial patch

Change History

11/04/08 10:37:32 changed by claude@2xlibre.net

  • needs_better_patch changed.
  • needs_tests changed.
  • needs_docs changed.

Moreover, you can quickly check the syntax on http://www.jslint.com/

11/06/08 04:24:25 changed by russellm

  • status changed from new to closed.
  • resolution set to fixed.

(In [9355]) Fixed #9518 -- Corrected example JSON snippet in fixture documentation. Thanks to claude@2xlibre.net for the report.

11/06/08 04:48:21 changed by russellm

(In [9356]) [1.0.X] Fixed #9518 -- Corrected example JSON snippet in fixture documentation. Thanks to claude@2xlibre.net for the report.

Merge of [9355] from trunk.

03/25/09 04:25:35 changed by hheimbuerger

  • status changed from closed to reopened.
  • resolution deleted.

Sorry, still incorrect. As shown in claude@2xlibre.net's correction, the outer list may not have a comma at the end either.

The last two lines have to be 

  }
]

not 

  },
]

04/02/09 09:03:29 changed by jacob

  • stage changed from Unreviewed to Accepted.
  • milestone set to 1.1.

04/02/09 12:48:10 changed by ramiro

  • attachment 9518.diff added.

Trivial patch

04/02/09 12:48:21 changed by ramiro

  • has_patch set to 1.

04/02/09 13:42:22 changed by jacob

  • owner changed from nobody to jacob.
  • status changed from reopened to assigned.

04/03/09 13:30:55 changed by jacob

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [10371]) Fixed a whole bunch of small docs typos, errors, and ommissions.

Fixes #8358, #8396, #8724, #9043, #9128, #9247, #9267, #9267, #9375, #9409, #9414, #9416, #9446, #9454, #9464, #9503, #9518, #9533, #9657, #9658, #9683, #9733, #9771, #9835, #9836, #9837, #9897, #9906, #9912, #9945, #9986, #9992, #10055, #10084, #10091, #10145, #10245, #10257, #10309, #10358, #10359, #10424, #10426, #10508, #10531, #10551, #10635, #10637, #10656, #10658, #10690, #10699, #19528.

Thanks to all the respective authors of those tickets.

Add/Change #9518 (Wrong JSON snippet on fixture documentation)




Change Properties
Action