Django

Code

Ticket #10359 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

Feed class reference contains false info

Reported by: minder Assigned to: jacob
Milestone: 1.1 Component: Documentation
Version: 1.0 Keywords:
Cc: Triage Stage: Accepted
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

http://docs.djangoproject.com/en/dev/ref/contrib/syndication/#feed-class-reference

I noticed this when I tried to make feed from objects that do not have get_absolute_url method (short messages for frontpage that don't need to have their own pages). I wrote item_link so that it points to the page that displayed recent messages but it turned out, that the feed readers were displaying only the last message - both rss and atom. It turned out this was caused by the lack of unique id for each item in the feed.

The only way to make unique ids I could find in the docs was item_guid method (it returns obj.id in my case) but the docs clearly state that this method is only used in atom feeds. It is not. I tried it with RSS feed and it worked.

Attachments

10359.patch (0.7 kB) - added by peterbe on 03/31/09 11:55:40.

Change History

02/28/09 13:10:56 changed by jacob

  • needs_better_patch changed.
  • needs_docs changed.
  • stage changed from Unreviewed to Accepted.
  • needs_tests changed.
  • milestone set to 1.1.

03/31/09 11:55:24 changed by peterbe

  • status changed from new to closed.
  • resolution set to fixed.

I've checked. The item_guid() is used by the Feed class just like it works for feed_type = Atom1Feed. So, not a feature just for Atom feeds like it said in the comment in the documentation. Patch attached.

03/31/09 11:55:40 changed by peterbe

  • attachment 10359.patch added.

03/31/09 18:55:55 changed by russellm

  • status changed from closed to reopened.
  • resolution deleted.

Not fixed until the patch is applied.

04/02/09 13:42:59 changed by jacob

  • owner changed from nobody to jacob.
  • status changed from reopened to assigned.

04/03/09 13:30:55 changed by jacob

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [10371]) Fixed a whole bunch of small docs typos, errors, and ommissions.

Fixes #8358, #8396, #8724, #9043, #9128, #9247, #9267, #9267, #9375, #9409, #9414, #9416, #9446, #9454, #9464, #9503, #9518, #9533, #9657, #9658, #9683, #9733, #9771, #9835, #9836, #9837, #9897, #9906, #9912, #9945, #9986, #9992, #10055, #10084, #10091, #10145, #10245, #10257, #10309, #10358, #10359, #10424, #10426, #10508, #10531, #10551, #10635, #10637, #10656, #10658, #10690, #10699, #19528.

Thanks to all the respective authors of those tickets.

Add/Change #10359 (Feed class reference contains false info)




Change Properties
Action