SelectDateWidget: field order as a result of DATE_FORMAT

[Bernd Schlapsi]

The SelectDateWidget had a fix output in the format: MONTH/DAY/YEAR.
It would be nice, if the format could follow the DATE_FORMAT in settings.py and take care of the correct order.

[Martin Conte Mac Donell <Reflejo@…>]

Actually SelectDateWidget isn't returning MONTH/DAY/YEAR format.

[Bernd Schlapsi]

This is the source-code for the render function of SelectDateWidget from trunk/django/newforms/extras/widgets.py

def render(self, name, value, attrs=None):
    try:
        value = datetime.date(*map(int, value.split('-')))
        year_val, month_val, day_val = value.year, value.month, value.day
    except (AttributeError, TypeError, ValueError):
        year_val = month_val = day_val = None

    output = []

    month_choices = MONTHS.items()
    month_choices.sort()
    select_html = Select(choices=month_choices).render(self.month_field % name, month_val)
    output.append(select_html)

    day_choices = [(i, i) for i in range(1, 32)]
    select_html = Select(choices=day_choices).render(self.day_field % name, day_val)
    output.append(select_html)

    year_choices = [(i, i) for i in self.years]
    select_html = Select(choices=year_choices).render(self.year_field % name, year_val)
    output.append(select_html)

    return mark_safe(u'\n'.join(output))

If I read/understand this function correct, the SelectDateWidget returns MONTH/DAY/YEAR format

[Martin Conte Mac Donell <Reflejo@…>]

I see, you mean the order not the literally "slash".

DATE_FORMAT Can take many variables that do not apply in select boxes. Consider this case: "%A, %B %Y". How do you render this?

[Bernd Schlapsi]

I know that DATE_FORMAT can take a lot of variables. I don't know a good solution yet. I am new to python and django, otherwise I would have tried to write a patch. But I think it's important to give this widget a bit of flexibility. In Europe we don't use the date format MONTH/DAY/YEAR.

Could it be a (good) solution to check the usual date formats? If none of them would be submitted, the widget could use a default date format. What do you think?

[David JL]

patch for ticket #6231

[David JL]

The patch above addresses this issue and also add a TimeSelectWidget.
It include regression tests.

David.

[Bernd Schlapsi]

New patch-version that works with current django-version (replaced newforms with forms)

[Bernd Schlapsi]

integrated patch for ticket #9124

[(none)]

Milestone post-1.0 deleted

[Jacob]

Please don't integrate patches like this; it makes things *really* hard to figure out. One patch per ticket.

[Bernd Schlapsi]

New patch-version that works with current django-version (after Changeset [10585])

[Marc Garcia]

(In [11412]) [soc2009/i18n] Fixed #6231. SelectDateWidget uses localized DATE_FORMAT setting.

[Marc Garcia]

Last commit shouldn't close the ticket, but Ref it. Reopening.

[Jannis Leidel]

(In [11964]) Fixed #7980 - Improved i18n framework to support locale aware formatting (dates and numbers) and form processing.

Thanks to Marc Garcia for working on this during his Google Summer of Code 2009!

Additionally fixes #1061, #2203, #3940, #5526, #6449, #6231, #6693, #6783, #9366 and #10891.