DecimalField tests with locale

[Dirk Datzert <dummy@…>]

I ran into an python locale issue with the DecimalField. During INSERTs and UPDATEs invalid sql-statements are generated since a comma-seperator ',' is used for formating DecimalField instead of the expected dot-seperator '.'

decimal-python.py (for simple testing):

from django.db.models.fields import DecimalField
from locale import setlocale, LC_NUMERIC
d = DecimalField(max_digits=6, decimal_places=3)
setlocale(LC_NUMERIC,'de_DE')
print d.format_number(3.456)
setlocale(LC_NUMERIC,'en_US')
print d.format_number(3.456)

---

linux-f426d:/home/admin/django/projects # export DJANGO_SETTINGS_MODULE=ais.settings
linux-f426d:/home/admin/django/projects # python decimal-python.py              
3,456
3.456

Environment:

• Django-SVN
• SuSE Linux Enterprise Server 10
• Python 2.4.2

On my private notebook this is no issue both outputs will be

3.456
3.456

Private Environment:

• Django-SVN
• OpenSuSe 10.3
• Python 2.5.1

[Dirk Datzert <dummy@…>]

short work-around for DecimalField format problems in db_prep methods

[Dirk Datzert <dummy@…>]

short work-around for DecimalField format problems in db_prep methods

[Philippe Raoult]

base tests for the issue

[Philippe Raoult]

my test machine doesn't have the appropriate locales but I'll run the tests tomorrow.

[Philippe Raoult]

slightly better tests

[Philippe Raoult]

The tests all pass with sqlite and mysql. I tried with both python 2.4.4 and 2.5.1. I'm marking ready for checking so we can commit the regression tests and hopefully get those run with other backends/versions.

Please note that the tests need the 'fr_FR' locale to run. If it's not available the test will be omitted (no failure though). If anyone has a more elegant solution I'd be happy to update the patch :)

[Malcolm Tredinnick]

Two problems here:

1. On a triage level, the test changes should have been part of the main patch. It took a while to realise that this "ready for checkin" thing was actually the second and the fourth patch.
2. More importantly, the solution isn't correct. setlocale() cannot be used in multi-threaded programs, since it changes the global locale, so it will affect the operation of other threads.

[yazzgoth]

I'm sorry to hijack this ticket.

I've uploaded a simple_patch.diff that should is a quick and dirty way of sorting this out.

[Philippe Raoult]

mtredinnick: sorry I wasn't explicit, but actually my plan was to commit only the tests, not the OP's patch. I haven't been able to reproduce the issue even though I use FR_fr on my servers.

[Dirk Datzert <dummy@…>]

Tests against Django 1.1 trunk rev 11368

[Dirk Datzert <dummy@…>]

Verbose Log output on running model_regress test which fails

[Marc Garcia]

I understand what's failing, but I don't understand what are you trying to achieve by using setlocale. Do you use it for displaying data on templates, and then you get errors from the db?

If that's the case, we should close this ticket as invalid, so the problem is not in Django, but in your code. As Malcolm says, you can't use setlocale in Django. Of course another ticket about being able to change number formats on Django would be correct. Actually it's not necessary, so this is already possible on the i18n branch.

[Jannis Leidel]

(In [11964]) Fixed #7980 - Improved i18n framework to support locale aware formatting (dates and numbers) and form processing.

Thanks to Marc Garcia for working on this during his Google Summer of Code 2009!

Additionally fixes #1061, #2203, #3940, #5526, #6449, #6231, #6693, #6783, #9366 and #10891.