Django

Code

Ticket #6230 (closed: fixed)

Opened 7 months ago

Last modified 4 months ago

SelectDateWidget don't render correctly (HTML error)

Reported by: Bernd Schlapsi Assigned to: nobody
Milestone: Component: django.newforms
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

SelectDateWidget generate an HTML-error (reference to non-existent ID "id_birthday")

This is the rendered HTML code:

<tr><th><label for="id_birthday">Birthday:</label></th><td><select name="birthday_month">
<option value="1">Januar</option>
<option value="2">Februar</option>
<option value="3">März</option>
<option value="4">April</option>
<option value="5">Mai</option>
<option value="6">Juni</option>
<option value="7">Juli</option>
<option value="8">August</option>
<option value="9">September</option>
<option value="10">Oktober</option>
<option value="11">November</option>
<option value="12">Dezember</option>
</select>
<select name="birthday_day">
<option value="1">1</option>
<option value="2">2</option>
<option value="3">3</option>
<option value="4">4</option>
<option value="5">5</option>
<option value="6">6</option>
<option value="7">7</option>
<option value="8">8</option>
<option value="9">9</option>
<option value="10">10</option>
<option value="11">11</option>
<option value="12">12</option>
<option value="13">13</option>
<option value="14">14</option>
<option value="15">15</option>
<option value="16">16</option>
<option value="17">17</option>
<option value="18">18</option>
<option value="19">19</option>
<option value="20">20</option>
<option value="21">21</option>
<option value="22">22</option>
<option value="23">23</option>
<option value="24">24</option>
<option value="25">25</option>
<option value="26">26</option>
<option value="27">27</option>
<option value="28">28</option>
<option value="29">29</option>
<option value="30">30</option>
<option value="31">31</option>
</select>
<select name="birthday_year">
<option value="1950">1950</option>
.....
<option value="1991">1991</option>
</select></td></tr>

Attachments

6230-1.diff (3.8 kB) - added by mattmcc on 12/21/07 03:09:02.
Patch to assign ids to the three select widgets in the format "id_<name>_<month,day,year>".
6230-2.diff (3.8 kB) - added by mattmcc on 01/30/08 17:19:01.

Change History

12/21/07 03:09:02 changed by mattmcc

  • attachment 6230-1.diff added.

Patch to assign ids to the three select widgets in the format "id_<name>_<month,day,year>".

12/21/07 03:12:23 changed by mattmcc

  • needs_better_patch changed.
  • has_patch set to 1.
  • needs_tests changed.
  • needs_docs changed.

12/26/07 12:43:51 changed by Bernd Schlapsi

I installed this patch on my local machine and tested it. It looks good for me. Would be great if this patch could be committed to trunk

01/20/08 21:12:23 changed by SmileyChris

  • needs_better_patch set to 1.
  • stage changed from Unreviewed to Accepted.

id_ = self.attrs.pop('id') doesn't seem like it belongs in render()

01/30/08 17:19:01 changed by mattmcc

  • attachment 6230-2.diff added.

01/30/08 17:19:30 changed by mattmcc

  • needs_better_patch deleted.

Agreed.

01/30/08 19:28:39 changed by anonymous

  • stage changed from Accepted to Ready for checkin.

01/30/08 19:28:58 changed by SmileyChris

(that was me)

03/18/08 09:20:43 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [7291]) Fixed #6230: Fixed the addition of id values to the select widgets in SelectDateWidget?. Thanks, Matt McClanahan?.


Add/Change #6230 (SelectDateWidget don't render correctly (HTML error))




Change Properties
Action