Changes between Version 5 and Version 6 of NewAdminChanges

Timestamp:

Oct 18, 2005, 3:25:51 PM (19 years ago)

Author:

rjwittams

Comment:

--

NewAdminChanges

@@ -2 +2 @@
 
 The new-admin branch contains a number of changes. All of these changes may be reverted (more likely with some than others) or further modified. 
+
+== View Functions ==
+
+For view functions to work properly with all new features, a few changes are in order. 
+
+From: 
+{{{
+def style_edit(request, object_id):    
+    try:
+        manipulator = styles.ChangeManipulator(object_id)
+    except ObjectDoesNotExist:
+        raise Http404
+
+    if request.POST:
+        new_data = request.POST.copy()
+        
+        errors = manipulator.get_validation_errors(new_data)
+        
+        if not errors:
+            manipulator.do_html2python(new_data)   # '''WRONG!!'''
+            manipulator.save(new_data)
+            return HttpResponseRedirect("")
+    else:
+        # Populate new_data with a "flattened" version of the current data.
+        new_data = manipulator.original_object.__dict__ # '''WRONG!!'''
+        errors = {}
+       
+        mash_around_with_the_data_dict_to_make_foreign_keys_work(new_data) # '''WRONG!!'''   
+
+    # Populate the FormWrapper.
+    form = formfields.FormWrapper(manipulator, new_data, errors)
+    
+    return render_to_response('style_edit', { 'form': form })
+}}}
+
+To:
+{{{
+def style_edit(request, object_id):    
+    try:
+        manipulator = styles.ChangeManipulator(object_id)
+    except ObjectDoesNotExist:
+        raise Http404
+
+    if request.POST:
+        new_data = request.POST.copy()
+        errors = manipulator.get_validation_errors(new_data)
+        
+        manipulator.do_html2python(new_data) # '''CORRECT!!'''
+        if not errors:
+            manipulator.save(new_data)
+            return HttpResponseRedirect("")
+    else:
+        # Populate new_data with a "flattened" version of the current data.
+        new_data = manipulator.flatten_data() # '''CORRECT!!'''
+        errors = {}
+       
+
+    # Populate the FormWrapper.
+    form = formfields.FormWrapper(manipulator, new_data, errors)
+    
+    return render_to_response('style_edit', { 'form': form })
+
+}}}
+Without these changes, the new fixes will not work. It should work about as well as the trunk without these changes. 
+
+So, 
+
+ 1. Make sure html2python is called regardless of whether there are errors, but *after* validation. 
+ 2. Make sure you use flatten_data to get your new_data to fill in your forms, NOT just the __dict__ of the object you are editing. Otherwise, dates, foreign keys, inline editing and a  whole host of other things will NOT work properly, just like they do not work on trunk. 
+ 3. Make sure you remove any hacks for modifying the data in your view function. This is now done by the fields themselves in flatten_data and instances where it works unexpectedly should be filed as bugs. 
 
 == Manipulators ==
@@ -20 +90 @@
 The data from a post must have {{{manipulator.do_html2python(new_data)}}} called on it before it is used to repopulate a formfieldwrapper.
 
-insert example
 
 == Templates ==