Changes between Version 27 and Version 28 of DjangoSpecifications/Core/Threading

Timestamp:

Apr 16, 2008, 8:04:22 AM (17 years ago)

Author:

mrts

Comment:

--

DjangoSpecifications/Core/Threading

@@ -78 +78 @@
 
 ||'''Module'''||'''Globals'''||'''Incomplete init'''||'''Inefficiencies'''||
-||settings and global_settings||?||not reviewed||||
-||utils/_decimal.py||lots, including code||not reviewed||||
+||settings and global_settings||?||MODULE LEVEL INIT, not reviewed||||
+||utils/_decimal.py||lots, including code||MODULE LEVEL INIT, not reviewed||||
 ||django/contrib/sites/models.py||`SITE_CACHE`||OK||one db hit intended, more than one possible||
 ||django/template/context.py||`_standard_context_processors`||OK||duplicated module loading with `__import__` possible||
 ||`django/template/__init__.py`||`invalid_var_format_string, libraries, builtins`||OK||duplicated module loading with `__import__` possible||
 ||django/template/loader.py||`template_source_loaders`||PROBLEM, see #6950, patch attached||duplicated module loading with `__import__` possible||
-||django/template/loaders/app_directories.py||`app_template_dirs`||MODULE LEVEL INIT (probably OK)||||
-||django/utils/translation/trans_real.py||`_accepted, _active, _default, _translations`||continue review here||foo||
-||django/core/urlresolvers.py||`_callable_cache, _resolver_cache`||`memoize` decorator||||
-||`django/core/serializers/__init__.py`||`_serializers`||||||
-||django/db/models/fields/related.py||`pending_lookups`||||||
-||django/db/transaction.py||`dirty, state`||||||
-||django/dispatch/dispatcher.py||`connections, senders, sendersBack||||||
+||django/template/loaders/app_directories.py||`app_template_dirs`||MODULE LEVEL INIT||||
+||django/utils/translation/trans_real.py||`_accepted, _active, _default, _translations`||OK||explicit threading support, no inefficiencies||
+||django/core/urlresolvers.py||`_callable_cache, _resolver_cache`||`memoize` decorator||duplicated module loading with `__import__` possible||
+||`django/core/serializers/__init__.py`||`_serializers`||PROBLEM, incomplete init in `_load_serializers`||||
+||django/db/models/fields/related.py||`pending_lookups`||OK?, needs further review||`append()` in `add_lazy_relation()` can add duplicated values, which may or may not confuse `pop()` in `do_pending_lookups()`||
+||django/db/transaction.py||`dirty, state`||OK||explicit threading support, no inefficiencies||
+||django/dispatch/dispatcher.py||`connections, senders, sendersBack||not reviewed||||
+
+=== Problems ===
+
+ 1. django/template/loader.py: the "bad" algorithm above, patch attached to #6950
+ 1. django/core/serializers/__init__.py: `_load_serializers()` is unsafe, patch attached to #FIXME:
+{{{
+1. thread 1: if not _serializers: true --> _load_serializers(), enter for loop
+2. thread 1: register_serializer(x)
+3. thread 2: if not _serializers: false --> use incomplete _serializers
+3. thread 1: register_serializer(y)
+}}}
+ 1. django/db/models/fields/related.py: `append()` in `add_lazy_relation()` can add duplicated values, which may or may not confuse `pop()` in `do_pending_lookups()`
 
 === Raw `grep` results ===