Changes between Version 18 and Version 19 of DjangoSpecifications/Core/Threading


Ignore:
Timestamp:
Apr 14, 2008, 2:11:58 PM (17 years ago)
Author:
mrts
Comment:

--

Legend:

Unmodified
Added
Removed
Modified

  • DjangoSpecifications/Core/Threading

    v18 v19  
    5454See below for raw `grep` results.
    5555
    56 ||'''Module'''||'''Globals'''||'''Notes'''||
    57 ||settings and global_settings||?||not reviewed||
    58 ||utils/_decimal.py||lots, including code||not reviewed||
    59 ||django/contrib/sites/models.py||`SITE_CACHE`||minor, one db hit intended, more than one possible||
    60 ||django/template/context.py||`_standard_context_processors`||||
    61 ||`django/template/__init__.py`||`invalid_var_format_string, libraries, builtins`||||
    62 ||django/template/loader.py||`template_source_loaders`||#6950, patch attached||
    63 ||django/template/loaders/app_directories.py||`app_template_dirs`||||
    64 ||django/utils/translation/trans_real.py||`_accepted, _active, _default, _translations`||||
    65 ||django/core/urlresolvers.py||`_callable_cache, _resolver_cache`||`memoize` decorator||
    66 ||`django/core/serializers/__init__.py`||`_serializers`||||
    67 ||django/db/models/fields/related.py||`pending_lookups`||||
    68 ||django/db/transaction.py||`dirty, state`||||
    69 ||django/dispatch/dispatcher.py||`connections, senders, sendersBack||||
     56||'''Module'''||'''Globals'''||'''Incomplete init'''||'''Inefficiencies'''||
     57||settings and global_settings||?||not reviewed||||
     58||utils/_decimal.py||lots, including code||not reviewed||||
     59||django/contrib/sites/models.py||`SITE_CACHE`||OK||one db hit intended, more than one possible||
     60||django/template/context.py||`_standard_context_processors`||OK||duplicated module loading with `__import__` possible||
     61||`django/template/__init__.py`||`invalid_var_format_string, libraries, builtins`||OK||duplicated module loading with `__import__` possible||
     62||django/template/loader.py||`template_source_loaders`||PROBLEM, see #6950, patch attached||duplicated module loading with `__import__` possible||
     63||django/template/loaders/app_directories.py||`app_template_dirs`||PROBABLY OK, appending to list at module level is not thread-safe, but the module is most likely cached ''before'' threads get access to it||||
     64||django/utils/translation/trans_real.py||`_accepted, _active, _default, _translations`||continue review here||foo||
     65||django/core/urlresolvers.py||`_callable_cache, _resolver_cache`||`memoize` decorator||||
     66||`django/core/serializers/__init__.py`||`_serializers`||||||
     67||django/db/models/fields/related.py||`pending_lookups`||||||
     68||django/db/transaction.py||`dirty, state`||||||
     69||django/dispatch/dispatcher.py||`connections, senders, sendersBack||||||
    7070
    7171=== Raw `grep` results ===
    … …  
    207207}}}
    208208
    209 As a matter of style, the read-only ones should really be tuples, not lists (the 'say what you mean' idiom -- if it shouldn't be modified, make it a tuple).
     209As a matter of style, the read-only ones should really be tuples, not lists -- the 'say what you mean' idiom: if it shouldn't be modified, don't let it be by making it a tuple. Tuples are also marginally more efficient speed- and space-wise. There is a slight semantic distinction between lists and tuples though http://jtauber.com/blog/2006/04/15/python_tuples_are_not_just_constant_lists/ . But as there are no constant lists in Python, tuples are the only way to be const-correct.
Back to Top