Changes between Version 13 and Version 14 of DjangoSpecifications/Core/Threading

Timestamp:

Apr 14, 2008, 2:00:01 AM (16 years ago)

Author:

mrts

Comment:

--

DjangoSpecifications/Core/Threading

@@ -25 +25 @@
 See below for raw `grep` results.
 
+||'''Module'''||'''Globals'''||'''Notes'''||
+||settings and global_settings||?||not reviewed||
+||utils/_decimal.py||lots, including code||not reviewed||
+
 '''THE FOLLOWING IS WORK IN PROGRESS.'''
 
@@ -30 +34 @@
 
 FIXME: not reviewed. Replacing the `global_settings` with `settings` -- probably no major issues.
+
+=== utils/_decimal.py ===
+
+FIXME: not reviewed. Lot's of globals, global code as well.
 
 === django/contrib/sites/models.py ===
@@ -94 +102 @@
 
 {{{
-$ rgrep '^[[:alnum:]_]\+ *= *{' django | egrep -v '(\.svn|_doctest\.py)' | sort
+$ grep -r '^[[:alnum:]_]\+ *= *{' django | egrep -v '(\.svn|_doctest\.py)' | sort
 }}}
 
@@ -159 +167 @@
 }}}
 
-Out of these, the following are read-only (i.e. not changed anywhere in code) or otherwise irrelevant: `contrib/admin, formtools tests, localflavor mappings, core/cache, core/handlers, core/serializers/__init__.py:BUILTIN_SERIALIZERS, core/servers, db/backends, db/models/query.py, utils/dates.py, utils/_decimal.py, utils/simplejson, utils/termcolors.py, utils/translation/trans_null.py`.
+Out of these, the following are read-only (i.e. not changed anywhere in code) or otherwise irrelevant: `contrib/admin, formtools tests, localflavor mappings`, `core/cache, core/handlers, core/serializers/__init__.py:BUILTIN_SERIALIZERS`, `core/servers, db/backends, db/models/query.py, utils/dates.py`, `utils/_decimal.py, utils/simplejson, utils/termcolors.py`, `utils/translation/trans_null.py`.
 
 `SITE_CACHE` and everything in `django.utils.translation.trans_real` has already been listed under `globals` above. 
@@ -180 +188 @@
 
 {{{
-$ rgrep '^[[:alnum:]_]\+ *= *\[' django | egrep -v '(\.svn|_doctest\.py)' | sort
+$ grep -r '^[[:alnum:]_]\+ *= *\[' django | egrep -v '(\.svn|_doctest\.py|__all__)' | sort
 }}}
 
@@ -186 +194 @@
 
 {{{
-django/conf/urls/defaults.py:__all__ = ['handler404', 'handler500', 'include', 'patterns', 'url']
-django/core/servers/basehttp.py:__all__ = ['WSGIServer','WSGIRequestHandler','demo_app']
-django/core/servers/fastcgi.py:__all__ = ["runfastcgi"]
 django/db/models/fields/__init__.py:BLANK_CHOICE_DASH = [("", "---------")]
 django/db/models/fields/__init__.py:BLANK_CHOICE_NONE = [("", "None")]
 django/template/__init__.py:builtins = []
 django/template/loaders/app_directories.py:app_template_dirs = []
-django/utils/checksums.py:__all__ = ['luhn',]
-django/utils/_decimal.py:__all__ = [
 django/utils/_decimal.py:rounding_functions = [name for name in Decimal.__dict__.keys() if name.startswith('_round_')]
 django/utils/_decimal.py:_signals = [Clamped, DivisionByZero, Inexact, Overflow, Rounded,
@@ -200 +203 @@
 django/utils/html.py:LEADING_PUNCTUATION  = ['(', '<', '&lt;']
 django/utils/html.py:TRAILING_PUNCTUATION = ['.', ',', ')', '>', '\n', '&gt;']
-django/utils/simplejson/decoder.py:__all__ = ['JSONDecoder']
 django/utils/simplejson/decoder.py:ANYTHING = [
-django/utils/simplejson/encoder.py:__all__ = ['JSONEncoder']
-django/utils/simplejson/__init__.py:__all__ = [
-django/utils/simplejson/scanner.py:__all__ = ['Scanner', 'pattern']
-django/utils/translation/__init__.py:__all__ = ['gettext', 'gettext_noop', 'gettext_lazy', 'ngettext',
-}}}
+}}}
+
+Leaving out the irrelevant read-only ones, the following remain:
+{{{
+django/template/__init__.py:builtins = []
+django/template/loaders/app_directories.py:app_template_dirs = []
+}}}
+
+As a matter of style, the read-only ones should really be tuples, not lists (the 'say what you mean' idiom -- if it shouldn't be modified, make it a tuple).