Changes between Version 11 and Version 12 of DjangoSpecifications/Core/Threading

Timestamp:

Apr 13, 2008, 3:16:34 PM (17 years ago)

Author:

mrts

Comment:

--

DjangoSpecifications/Core/Threading

@@ -21 +21 @@
  1. global mutable data structures (lists and dictionaries, also instances) that are assigned to at module level but whose elements are modified in functions and that are accessed without using the `global` keyword (NOT THREAD-SAFE unless never modified).
 
-We won't deal with read-only globals. `grep` in Django source finds the following other globals.
+The following modules' use of globals needs review.
+
+See below for raw `grep` results.
+
+'''THE FOLLOWING IS WORK IN PROGRESS.'''
+
+=== Settings ===
+
+FIXME: not reviewed. Replacing the `global_settings` with `settings` -- probably no major issues.
+
+=== django/contrib/sites/models.py ===
+
+Globals used:
+{{{
+SITE_CACHE
+}}}
+
+=== django/template ===
+
+Globals used:
+{{{
+context.py: _standard_context_processors
+__init__.py: invalid_var_format_string, libraries
+loader.py: template_source_loaders
+}}}
+
+=== django/utils/translation ===
+
+Globals used:
+{{{
+trans_real.py: _accepted, _active, _default, _translations
+}}}
+
+=== django/contrib/sites/models.py ===
+
+Globals used:
+{{{
+SITE_CACHE
+}}}
+
+
+
+{{{
+}}}
+
+== Raw `grep` results ==
 
 === Globals accessed with the `global` keyword ===
@@ -43 +88 @@
 django/utils/translation/trans_real.py:    global _translations
 }}}
+
+Out of these, `django.core.management` is not used in multi-threading context.
 
 === Global dictionaries ===
@@ -112 +159 @@
 }}}
 
+Out of these, the following are read-only (i.e. not changed anywhere in code) or otherwise irrelevant: `contrib/admin, formtools tests, localflavor mappings, core/cache, core/handlers, core/serializers/__init__.py:BUILTIN_SERIALIZERS, core/servers, 
+
+`SITE_CACHE` and everything in `django.utils.translation.trans_real` has already been listed under `globals` above. 
+
+`_callable_cache` and `_resolver_cache` in django/core/urlresolvers.py are used within the memoize decorator, `result = func(*args)` may be called more than once in `utils/functional.py`, but this should generally be a non-issue.
+
+That leaves the following relevant global dicts not listed before:
+{{{
+django/core/serializers/__init__.py:_serializers = {}
+}}}
+
 === Global lists ===