Code

Changes between Version 19 and Version 20 of DjangoSpecifications/Core/SingleInstance


Ignore:
Timestamp:
03/25/08 06:30:13 (6 years ago)
Author:
PhiR
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • DjangoSpecifications/Core/SingleInstance

    v19 v20  
    116116== Discussions == 
    117117=== Internal API === 
    118 The current patch design overrides the !__call!__ method for the model base which means it automatically returns singleton instances when available. This is convenient because XXX (David or Brian: feel free to fill this out). 
     118''(David)'' The current patch design overrides the !__call!__ method for the model base which means it automatically returns singleton instances when available. This is convenient because XXX (David or Brian: feel free to fill this out). 
    119119 
    120 Another approach would be to make this explicit and have a simple API along the lines of: 
     120''(Philippe)'' Another approach would be to make this explicit and have a simple API along the lines of: 
    121121{{{ 
    122122class ModelBase: 
     
    129129=== Default behavior === 
    130130Should this feature be enabled by default ?  
    131  * Philippe: It should be because it really makes the ORM behave more correctly but for the sake of backward compatibility let's fist commit off by default. We can  
    132 change the default parameter value later, and in the meantime honor a global setting to turn it on for all models. 
     131 * ''(Philippe)'' It should be because it really makes the ORM behave more correctly but for the sake of backward compatibility let's fist commit off by default. We can change the default parameter value later, and in the meantime honor a global setting to turn it on for all models. 
    133132 
    134  * David: This would always be enabled. You cannot turn it off. If stuff is broken by having this on then it should be broken. 
    135 This can cause problems with serializers, and things that modify querysets and shouldn't (e.g. .extra). That is the only reason it should be turned off. If those problems are addressed there is no reason to use #17 and to have it enabled 100% of the time. 
     133 * ''(David)'' This would always be enabled. You cannot turn it off. If stuff is broken by having this on then it should be broken. This can cause problems with serializers, and things that modify querysets and shouldn't (e.g. .extra). That is the only reason it should be turned off. If those problems are addressed there is no reason to use #17 and to have it enabled 100% of the time. 
    136134 
    137135=== extra, values ===