Changes between Version 1 and Version 2 of DjangoSpecifications/Core/SingleInstance

Timestamp:

Mar 22, 2008, 7:19:22 PM (16 years ago)

Author:

Philippe Raoult

Comment:

--

DjangoSpecifications/Core/SingleInstance

@@ -25 +25 @@
     print "%s (%s)" % (article.title, article.type_of_article.name)
 }}}
-If you have a great number of Articles and a smaller number of ArticleTypes the perfomance/memory hit is staggering:
+If you have a great number of Articles and a smaller number of ArticleTypes the performance/memory hit is staggering:
  * you do a request per Article to get the type
  * you have as many ArticleType instances in memory as there are articles
 
+=== Threads ===
+No sharing would occur between threads, as is the case currently. Instances will be unique within each thread. 
+
 == Implementation ==
-#17 currently has a working patch doing the following:
- * 
-
+#17 currently has a working patch with the following:
+ * Per-model WeakValueDictionary with dict[pk_val] = instance.
+ * __call__ classmethod which either gets a instance from the dict or return a newly created one.
+ * a simple interface for enabling or disabling the feature for a given Model (default is disabled).
+ * a slightly modified related manager which will first try to get the instance from the Model dict instead of blindly querying the DB.
+ * slightly modified serializers to force the instantiation when reading from an outside source.
+ * a slightly modified query to force flushing instances when they are delete'd from the DB.
+ * tests! 
 
 but some things are missing: 
-* more detailled docs
-* API cleanup
+ * there is no doc as to how to enable/disable this feature and what to expect from it.
+ * the API for enabling/disabling the feature is very crude and consists only of two class methods. It should at the very least be possible to set the value as a member of the Meta class. 
+ * the Model dict should be set threadlocally 
 
 
 
-=== Threads ===
-The current #17 patch does not handle threads but the design calls for per-thread instance uniqueness only. No sharing would occur between threads, as is the case currently.
 
-