Changes between Version 13 and Version 14 of DjangoSpecifications/Core/SingleInstance

Timestamp:

Mar 25, 2008, 4:44:00 AM (16 years ago)

Author:

David Cramer

Comment:

--

DjangoSpecifications/Core/SingleInstance

@@ -122 +122 @@
 }}}
 That means writing Model(kwargs) would always return a fresh instance and bypass the instance. Since Django's ORM would use the API internally, doing Model.objects.get would (by default, overridable in the manager) return the singleton. The default related manager would also have a new get_from_db method to force retrieving and instantiating from the DB only. 
+
+== Proposal #2 (The Original Proposal) ==
+This would always be enabled. You cannot turn it off. If stuff is broken by having this on then it should be broken.
+
+This can cause problems with serializers, and things that modify querysets and shouldn't (e.g. .extra). That is the only reason it should be turned off. If those problems are addressed there is no reason to use #17 and to have it enabled 100% of the time.
+
+A simple workaround querysets, and this would branch into being able to store .values() as partials as well (this code is untested, but should give a general idea):
+
+{{{
+class SphinxObjectInstance(object):
+    """
+    Acts exactly like a normal instance of an object except that
+    it will handle any special sphinx attributes in a __sphinx class.
+    """
+    _reserved_attributes = ('_sphinx', '__instance')
+    
+    def __init__(self, instance, attributes={}):
+        object.__setattr__(self, '__instance', instance)
+        object.__setattr__(self, '_sphinx', SphinxAttributes(attributes))
+    
+    def __setattr__(self, name, value):
+        if name in _reserved_attributes:
+            return object.__setattr__(self, name, value)
+        return setattr(self.instance, name, value)
+
+    def __getattr__(self, name, value=None):
+        if name in _reserved_attributes:
+            return object.__getattr__(self, name, value)
+        return getattr(self.instance, name, value)
+}}}
+
+The proposal would also change how extra is used, it should probably be instance._extra or something similar.
+
+(The code above is taken from an unpublished update to the django-sphinx package.)