Changes between Version 4 and Version 5 of CustomFormFields

Timestamp:

Feb 24, 2006, 5:16:50 PM (19 years ago)

Author:

Lllama

Comment:

--

CustomFormFields

@@ -39 +39 @@
 
 2006-02-20-16:20-ish
+
 Looks like do_html2python is our friend here.  In line with the [wiki:NewAdminChanges new admin documentation] we need to make sure that do_html2python is called regardless of whether there are any errors.  In doing so we can get our list of IDs in a 'neat' manner.  The only problem?  What if we've got validation errors? Trying to convert the data fails when there are errors.  Which means we can't convert.  Which means that render doesn't get its nice list of IDs anymore.  Stumped.
+
+2006-02-24-23:14-ish
+
+While watching Firefly I've come up with this:
+
+{{{
+class FormPortField(formfields.TextField):
+
+    requires_data_list = True
+
+    def __init__(self, **kw):
+        formfields.TextField.__init__(self, **kw)
+        self.validator_list.append(self.isValidList)
+
+    def isValidList(self, field_data, all_data):
+        for datum in field_data:
+            for port in datum.split(','):
+                if port.lower().strip() != 'icmp':
+                    try:
+                        no, proto = port.split(':')
+                    except ValueError:
+                        raise validators.ValidationError, _("Ports should be specified in the form 'number:protocol'.  E.g. '80:tcp'")
+                    try:
+                        if int(no) < 1 or int(no) > 65355:
+                            raise validators.ValidationError, _("Port number must be between 1 and 65355")
+                    except ValueError:
+                        raise validators.ValidationError, _("Port number must be between 1 and 65355")
+                    if proto.lower().strip() not in ['tcp', 'udp']:
+                        raise validators.ValidationError, _("Protocol must be either 'TCP' or 'UDP'")
+
+    def render(self, data):
+        if data is None:
+            data = ''
+        if isinstance(data, unicode):
+            data = data.encode(DEFAULT_CHARSET)
+        tmp = []
+        for datum in data:
+            try:
+                port = ports.get_object(id__exact=int(datum))
+                if port.number:
+                    tmp.append("%s:%s" % (port.number, port.protocol))
+                else:
+                    tmp.append("%s" % (port.protocol, ))
+            except ValueError:
+                # By catching this error we now assume that it's invalid data entered by the user and
+                # so should simply be returned in the 'raw'
+                return '<input type="text" id="%s" class="v%s%s" name="%s" size="%s" value="%s" />' % \
+                (self.get_id(), self.__class__.__name__, self.is_required and ' required' or '',
+        data = ', '.join(tmp)
+        return '<input type="text" id="%s" class="v%s%s" name="%s" size="%s" value="%s" />' % \
+            (self.get_id(), self.__class__.__name__, self.is_required and ' required' or '',
+            self.field_name, 40, escape(data))
+
+    def convert_post_data(self, new_data):
+        name = self.get_member_name()
+        if new_data.has_key(self.field_name):
+            d = new_data.getlist(self.field_name)
+            try:
+                self.isValidList(d, new_data)
+            except validators.ValidationError:
+                return
+            portlist=[]
+            for datum in d:
+                for n in datum.split(','):
+                    n = n.strip()
+                    if n:
+                        if n.lower() == 'icmp':
+                            portlist.append(ports.get_object(protocol__exact="icmp").id)
+                        else:
+                            port, proto = n.split(':')
+                            port_ref = ports.get_object(number__exact=int(port), protocol__exact=proto.lower())
+                            portlist.append(port_ref.id)
+            new_data.setlist( name, portlist)
+}}}
+
+Wow.  What a mess.  We end up validating the data three times over.  What a pain.  But it works.