Changes between Version 9 and Version 10 of AuditTrail

Timestamp:

Oct 1, 2007, 1:02:33 PM (17 years ago)

Author:

George Vilches

Comment:

Fixed maxlength/max_length problem, added I/U distinction on save(), fixed problem with Field.unique.

AuditTrail

@@ -56 +56 @@
 As you can see, the audit trail is listed with the most recent state first. Each entry also inclues a timestamp when the edit took place.
 
-Saves and deletes are both tracked, and can be filtered on via {{{ Person.history.filter(_audit_change_type='_') }}}.  Do not use underscore, use 'U' for inserts/updates, and 'D' for deletes.  If #4879 lands, then we will be able to distinguish between inserts and updates, and at that point the audit trail will use 'I' for inserts and 'U' for updates.
+Saves and deletes are both tracked, and can be filtered on via {{{ Person.history.filter(_audit_change_type='_') }}}.  Do not use underscore, use 'I' for inserts, 'U' for updates, and 'D' for deletes.
 
 ForeignKeys and OneToOneFields are now supported both for saving and accessing the audit data.  However, it does not archive the contents of the ForeignKey table for the appropriate entries at the same time, and will fail if the ForeignKey a given audit entry is related to is deleted (including if you're auditing the ForeignKey table as well, it does not have a way to link the two audit tables together).
@@ -172 +172 @@
                             return field_arr[2]
 
-            def _audit(sender, instance):
+            def _audit(sender, instance, created):
                 # Write model changes to the audit model.
                 # instance is the current (non-audit) model.
@@ -180 +180 @@
                     kwargs[field.name] = getattr(instance, field.name)
                 if self.opts['save_change_type']:
-                    kwargs['_audit_change_type'] = 'U'
+                    if created:
+                        kwargs['_audit_change_type'] = 'I'
+                    else:
+                        kwargs['_audit_change_type'] = 'U'
                 for field_arr in model._audit_track:
                     kwargs[field_arr[0]] = _audit_track(instance, field_arr)
@@ -247 +250 @@
         'Meta': Meta,
         '_audit_id': models.AutoField(primary_key=True),
-        '_audit_timestamp': models.DateTimeField(auto_now_add=True),
+        '_audit_timestamp': models.DateTimeField(auto_now_add=True, db_index=True),
         '_audit__str__': cls.__str__.im_func,
         '__str__': lambda self: '%s as of %s' % (self._audit__str__(), self._audit_timestamp),
@@ -254 +257 @@
 
     if 'save_change_type' in kwargs and kwargs['save_change_type']:
-        attrs['_audit_change_type'] = models.CharField(maxlength=1)
+        attrs['_audit_change_type'] = models.CharField(max_length=1)
 
     if 'show_in_admin' in kwargs and kwargs['show_in_admin']:
@@ -272 +275 @@
         else:
             attrs[field.name] = copy.copy(field)
+            # If 'unique' is in there, we need to remove it, otherwise the index
+            # is created and multiple audit entries for one item fail.
+            attrs[field.name].unique = False
 
     for track_field in _track_fields(kwargs['track_fields']):