Changes between Initial Version and Version 1 of Ticket #9631, comment 9
- Timestamp:
- Jan 9, 2019, 4:07:55 PM (6 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #9631, comment 9
initial v1 1 1 > Why wouldn't it be appropriate to return file.size whether it's committed or not? That's the implementation suggested by the initial patch here. 2 2 3 `self.file` could be `None` unless the file has been opened. But maybe that check should instead be for `_file`, like the `open()` method. It looks like the code path for using `file.size` was added for efficiency in the first place in 68a890e79f6 .3 `self.file` could be `None` unless the file has been opened. But maybe that check should instead be for `_file`, like the `open()` method. It looks like the code path for using `file.size` was added for efficiency in the first place in 68a890e79f660484d05482902663b6168f0bd71e.