Code

Changes between Initial Version and Version 2 of Ticket #9284


Ignore:
Timestamp:
03/19/09 20:07:32 (5 years ago)
Author:
jkocherhans
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9284

    • Property Status changed from new to reopened
    • Property Patch needs improvement unset
    • Property Needs tests unset
    • Property Summary changed from Formsets don't call form's save to BaseModelFormSet and BaseInlineFormSet should call ModelForm.save() when saving objects
    • Property Needs documentation unset
    • Property Has patch set
    • Property Triage Stage changed from Unreviewed to Design decision needed
  • Ticket #9284 – Description

    initial v2  
    1 Would it not be better to have the formset call each form's save method explicitly when the formset's save is called? 
    2 It seems it would make some logic more centralized. 
     1The most current code is at http://github.com/jkocherhans/django/tree/formset-updates 
     2 
     3This introduces some backwards incompatibilities for people who overrode either type of formset's {{{__init__}}} method, but this is how I would have written the model formset code if we'd actually had modelforms first. This doesn't really solve any specific problems that I know of.