Changes between Initial Version and Version 1 of Ticket #8291, comment 17
- Timestamp:
- Feb 4, 2012, 12:09:02 PM (13 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #8291, comment 17
initial v1 1 It looks like the resolution of ordering fields now gets run through Query.setup_joins which uses get_field_by_name by resolve the pk alias to the actual primary keyfield. So, lukeplant, you're correct that the change to options.py is no longer necessary. Now to look at validation.py and see if there's a better general purpose solution than excluding "pk" from going through ordering validation ...1 It looks like the resolution of ordering fields now gets run through Query.setup_joins which builds a list of field aliases, including pk, to use in resolving to the actual model field. So, lukeplant, you're correct that the change to options.py is no longer necessary. Now to look at validation.py and see if there's a better general purpose solution than excluding "pk" from going through ordering validation ...