Opened 12 years ago

Last modified 8 years ago

#6735 closed

Class-based generic views — at Version 8

Reported by: jkocherhans Owned by: nobody
Component: Generic views Version:
Severity: Keywords:
Cc: Daniel Duan, floguy@…, David Larlet, Carl Meyer, Jannis Leidel, sciyoshi@…, vbmendes@…, anossov@…, mjmalone@…, taavi@…, narma.nsk@…, Oliver Beattie, Aaron C. de Bruyn, Jari Pennanen, brian@…, ssteinerX@…, drbob@…, ben@…, Alexander Koshelev, Chris Chambers, Brandon Konkle, Henrique Romano Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by jkocherhans)

Rewrite generic view to be class based, but leave the existing generic views as-is for now.

Change History (12)

Changed 12 years ago by jkocherhans

Attachment: new-generic-views.diff added

comment:1 Changed 12 years ago by jkocherhans

This ticket refs #3639 use newforms in generic create_update view

comment:2 Changed 12 years ago by jkocherhans

Needs documentation: set
Needs tests: set

The tests need to be fleshed out a little more, and we need a plan for backwards compatibility, but the classes themselves are fairly close, I think.

comment:3 Changed 12 years ago by floguy

Cc: floguy@… added

comment:5 Changed 12 years ago by Jacob

Triage Stage: UnreviewedDesign decision needed

Changed 12 years ago by jkocherhans

Attachment: new-generic-views.2.diff added

Changed 12 years ago by jkocherhans

Attachment: new-generic-views.3.diff added

comment:6 Changed 12 years ago by jkocherhans

post_save is now on_success and I've added hook to return the rendered template.

comment:7 Changed 12 years ago by jkocherhans

Needs tests: unset
Triage Stage: Design decision neededAccepted

Sorry about the mess of patch files. I forgot to check the "replace me" box. Anyhow, Adrian and Jacob are both in favor after a discussion today, so I'm changing status to Accepted.

Changed 12 years ago by jkocherhans

Attachment: generic-views.diff added

Now list_detail views can play too.

comment:8 Changed 12 years ago by jkocherhans

Description: modified (diff)
Summary: Class-based generic create/update/delete viewsClass-based generic views
Note: See TracTickets for help on using tickets.
Back to Top