Changes between Initial Version and Version 1 of Ticket #6369


Ignore:
Timestamp:
Jan 12, 2008, 11:29:00 PM (16 years ago)
Author:
Gary Wilson
Comment:

Sounds like the right thing to do. It's even a TODO in the code comments :)

As far as the patch goes, assigning directly to keyOrder is not a good idea. IMO, keyOrder looks like it should be a private attribute. Anyway, by blindly assigning to keyOrder without checking to see if those keys exist in the SortedDict would cause bad things to happen.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #6369

    • Property Patch needs improvement set
    • Property Needs documentation set
    • Property Needs tests set
    • Property Triage Stage Unreviewed → Accepted

  • Ticket #6369 – Description

    initial v1  
    33Right now, this is accomplished with:
    44{{{
     5#!python
    56class myForm(forms.ModelForm):
    67    def __init__(self, *args, **kwargs):
    … …  
    1415The new version would just be:
    1516{{{
     17#!python
    1618class myForm(forms.ModelForm):
    1719    class Meta:
Back to Top