Changes between Initial Version and Version 1 of Ticket #4282, comment 15


Ignore:
Timestamp:
Nov 19, 2021, 11:27:29 PM (2 years ago)
Author:
Ad Timmering

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #4282, comment 15

    initial v1  
    11Thanks for context Claude.
    22
    3 I have updated the original PR - however got stuck on the fact that `subprocess.run()` does not support `umask` (at least not prior to 3.9), and just setting `umask` has no effect - which renders this untestable. If you (or anyone reading this) has any suggestions please lmk.
     3I have started a PR based on the original.
    44
    5 PR that does not passes the tests (because of `umask`):
    6 https://github.com/django/django/pull/15102
     5What has changed since the original is that django-admin is now called with `subprocess.run()`, where setting `umask` is only possibly since 3.9. (Discussion on introduction of `umask` and [lack of] alternatives at https://bugs.python.org/issue38417).
     6Would it be OK to write the tests so they are only run on >=3.9 ?
     7
     8I'll try and fix the PR to reflect that first and flag it ready for review once done.
Back to Top