Changes between Initial Version and Version 1 of Ticket #4136, comment 43


Ignore:
Timestamp:
04/01/17 06:47:24 (6 years ago)
Author:
Matt Braymer-Hayes
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4136, comment 43

    initial v1  
    1 Hi folks, question: Do these changes also impact `models.CharField` subclasses (`CommaSeparatedIntegerField`, `EmailField`, `SlugField`, and `URLField`) and `forms.CharField` subclasses (`RegexField`, `EmailField`, `URLField`, `GenericIPAddressField`, `SlugField`, and `UUIDField`)? If so, the docstrings and documentation for each of the `forms.CharField` subclasses should be updated. I'm happy to make a PR, if this is the case.
     1Hi folks, question: Do these changes also impact `models.CharField` subclasses (`CommaSeparatedIntegerField`, `EmailField`, `SlugField`, and `URLField`) and `forms.CharField` subclasses (`RegexField`, `EmailField`, `URLField`, `GenericIPAddressField`, `SlugField`, and `UUIDField`)? Based on my review of the code they do, though I may be missing something. If they are, the docstrings and documentation for each of the `forms.CharField` subclasses should be updated. I'm happy to make a PR, if this is the case.
Back to Top