Opened 17 years ago

Last modified 14 years ago

#4092 closed

django/contrib/localflavor/usa/forms.py USStateSelect missing blank options — at Version 3

Reported by: polpak <polpak@…> Owned by: Adrian Holovaty
Component: contrib.localflavor Version: dev
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Malcolm Tredinnick)

This field needs to have the default starting option of ('', '----------') so people don't accidentally forget to change it and have a bunch of submissions for Alabama.

I can submit a patch for this later on if needed

Chad Simmons

Change History (3)

comment:1 by polpak <polpak@…>, 17 years ago

.... it stripped off the blank value ticktick

comment:2 by Simon G. <dev@…>, 17 years ago

Component: Uncategorizeddjango.contrib.localflavor
Owner: changed from Jacob to Adrian Holovaty
Triage Stage: UnreviewedAccepted

comment:3 by Malcolm Tredinnick, 17 years ago

Description: modified (diff)

(Fixed description formatting)

I'm not really sure what to do about this. The blank entry (if we include it), should be inserted by the widget, since it's not part of the data. And possibly only inserted if no choice is selected. We should also do the same thing for every other localflavor widget; nothing special about the US version here.

Patches welcome, certainly. Something to look at might make it easier to decide.

Note: See TracTickets for help on using tickets.
Back to Top