Changes between Initial Version and Version 1 of Ticket #37435, comment 8


Ignore:
Timestamp:
Oct 18, 2026, 4:45:08 AM (3 weeks ago)
Author:
harshit gupta

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #37435, comment 8

    initial v1  
    1 Replying to [comment:7 harshit gupta]:
    2 > Replying to [comment:6 David Smith]:
    3 > > I am not sure we should be micro-optimising for a scenario when there are tens of thousands of on_commit callbacks in play.
    4 >
    5 > Hi David, I understand that large callback queues aren’t typical. I think this is worth merging because a small internal change removes quadratic queue overhead, with no new public API or additional queue. The benchmarks show gains for larger batches, and tests cover ordering, exceptions, and callback lifetimes. I recognise that small queues don’t consistently improve.
    6 > I’m 17 and excited to contribute to Django. I’d love to see this land, and I’m happy to work through any remaining concerns :)
     1i also got some more micro optimizations in the bag o(n**2) to o(n) in general terms.
Back to Top