Opened 3 weeks ago
Last modified 12 days ago
#37294 assigned Cleanup/optimization
Run Playwright tests against non-chromium browsers as well in CI
| Reported by: | Varun Kasyap Pentamaraju | Owned by: | Varun Kasyap Pentamaraju |
|---|---|---|---|
| Component: | Testing framework | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
After selenium to playwright migration, the tests are less flaky in non chromium browsers, and it might be a good time to raise the bar.
Playwright tests already support multiple browsers (--playwright=chromium,firefox,webkit). but, CI runs chromium only.
We could discuss and agree upon how we can add other browsers to CI.
Change History (4)
comment:1 by , 2 weeks ago
comment:2 by , 2 weeks ago
The admin FAQ says:
The admin provides a fully-functional experience to the recent versions of modern, web standards compliant browsers. On desktop this means Chrome, Edge, Firefox, Opera, Safari, and others.
Chrome, Edge, and Opera share the Chromium engine, so they are covered. That leaves Firefox and Safari. Playwright's webkit is the usual CI stand for Safari.
Current CI
| Workflow | Trigger | SQLite | PostgreSQL | Screenshots |
|---|---|---|---|---|
playwright.yml | PR with the playwright label | Chromium | Chromium | — |
schedule_tests.yml | Daily | Chromium | Chromium | — |
screenshots.yml | PR with the screenshots label | — | — | Chromium |
Proposed CI
| Workflow | Trigger | SQLite | PostgreSQL | Screenshots |
|---|---|---|---|---|
playwright.yml | PR with the playwright label | Chromium, Firefox, WebKit | Chromium | — |
schedule_tests.yml | Daily | Chromium, Firefox, WebKit | Chromium | — |
screenshots.yml | PR with the screenshots label | — | — | Chromium |
We could at least add Firefox and WebKit to the daily SQLite job first and watch that for a while. If it stays useful, we can add the same browsers to the labeled PR workflow.
PostgreSQL can stay on Chromium only. These tests exercise the admin UI in browsers. the database backend should not change the result. Screenshots can stay on Chromium.
comment:3 by , 2 weeks ago
| Triage Stage: | Unreviewed → Accepted |
|---|
Thanks for all your efforts in this space.
Given your knowledge in this area could you give a proposal of what you think that CI should look like in terms of browser support, frequency and so on.