Changes between Initial Version and Version 1 of Ticket #37174, comment 6


Ignore:
Timestamp:
Jun 23, 2026, 2:27:48 PM (2 weeks ago)
Author:
Juan Pedro Roldán

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #37174, comment 6

    initial v1  
    11Hi,
    22
    3 I reviewed this ticket while looking for a small code-related contribution. I noticed it is already assigned, so I won’t work on it directly.
    4 I reproduced the issue locally using the PoC from the description with `make_template_fragment_key("frag", ["alice", "b:c"])` and `make_template_fragment_key("frag", ["alice:b", "c"])`. Both calls currently produce the same cache key:
     3I was reviewing this ticket while looking for a small code-related contribution to understand Django’s contribution workflow. I noticed that the ticket is already assigned, so I won’t work on it directly.
     4
     5I tried to reproduce the issue locally using the example from the ticket description:
     6
     7`make_template_fragment_key("frag", ["alice", "b:c"])`
     8
     9and
     10
     11`make_template_fragment_key("frag", ["alice:b", "c"])`
     12
     13Both calls generated the same cache key:
     14
    515`template.cache.frag.486f15e693cb74d155ff00eb53e7e306`
    6 I also added a small local regression test in `tests/cache/tests.py` under `TestMakeTemplateFragmentKey`:
    7 `test_vary_on_values_with_colons_do_not_collide`
    8 As expected, the test fails on the current branch, confirming the reported behavior.
    916
    10 I hope this helps with triage/testing. I’d be happy to test a proposed patch if needed.
     17I also added a small local regression test in `tests/cache/tests.py`, inside `TestMakeTemplateFragmentKey`, to check that these two keys should be different. As expected, the test fails on the current branch, so the reported behavior is reproduced.
     18
     19I hope this helps with testing or triage. I’d be happy to test a proposed patch if needed.
Back to Top