Changes between Initial Version and Version 1 of Ticket #36988, comment 10


Ignore:
Timestamp:
Nov 5, 2026, 7:23:19 AM (9 days ago)
Author:
SnippyCodes

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #36988, comment 10

    initial v1  
    11Following up on @smithdc1's review regarding API design and avoiding settings bloat, here is a consolidated proposal to resolve #36988 cleanly without introducing new global settings or fragile substring checks.
    22
    3 ### Background & Constraints:
     3Background & Constraints:
    441. **Regressions with Substring Checks:** As noted by David, pattern matching against "City" or "Country" has historically regressed (#15892, #18677).
    552. **Settings Bloat:** Adding `GEOIP_SUPPORTED_DATABASE_TYPES` was rejected because Django aims to keep global settings minimal.
    663. **The Core Problem:** Commercial DB-IP editions (`DBIP-City`, `DBIP-Country`) and valid third-party databases (e.g., `Geoacumen-Country`) are blocked by the hardcoded `SUPPORTED_DATABASE_TYPES` set, forcing users to monkey-patch private module attributes.
    77
    8 ### Proposed 3-Tier Solution:
     8Proposed Solution:
    99
    10101. **Native Support for Missing Commercial Editions:**
Back to Top