Changes between Initial Version and Version 1 of Ticket #36809, comment 13
- Timestamp:
- Feb 1, 2026, 1:05:53 AM (4 weeks ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #36809, comment 13
initial v1 1 1 Thanks Mike for the review. I think defining subclass is not a good option which makes duplication of code as you describe. Defining explicit methods like I did will makes the code more readable and will avoid duplication. 2 In my current PR I made some changes like the methods **validate_domain()** and **validate_username()** will return boolean so we need to wrap the methods inside ** __call__**. Now I am confused about do I have to make these two methods to raise **ValidationError** then no need for wrapping inside **__call__** or left as it is?2 In my current PR I made some changes like the methods **validate_domain()** and **validate_username()** will return boolean so we need to wrap the methods inside **call**. Now I am confused about do I have to make these two methods to raise **ValidationError** then no need for wrapping inside **call** or left as it is?