Opened 71 minutes ago

Last modified 70 minutes ago

#36768 new Bug

File.__iter__() Quadratic-time DoS — at Version 1

Reported by: wooseokdotkim Owned by:
Component: Uncategorized Version:
Severity: Normal Keywords: DoS
Cc: wooseokdotkim Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by wooseokdotkim)

I thought the code below could generate DoS, so I made a bug report
However, File._iter was not recognized as a bug because only one line was buffered and only worked for chunks returned from File.chunks, but it was determined that verification code for input should be added, so it was created as an open ticket.

The code pattern is similar to CVE-2023-36053, which is already released, so I think it needs to be modified.

code: django/core/files/base.py:89

def __iter__(self):
    buffer_ = None
    for chunk in self.chunks():
        for line in chunk.splitlines(True):
            if buffer_:
                line = buffer_ + line  # < Code!

How should I patch it?

Change History (1)

comment:1 by wooseokdotkim, 70 minutes ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.
Back to Top