Changes between Initial Version and Version 1 of Ticket #36739, comment 2


Ignore:
Timestamp:
Nov 17, 2025, 8:29:37 AM (3 hours ago)
Author:
Simon Charette

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #36739, comment 2

    initial v1  
    55The question now becomes whether we want **all** checks that potentially access the database to be tagged with `Tag.database`. From my understanding the `Tag.database` tag was meant to convey ''check that the database is setup properly'' and never ''might potentially access the database'' so in this sense I don't think it would be appropriate.
    66
    7 Another way to see it is that `staticfiles` checks could perform access control gated I/O to determine if they are properly setup (e.g. has access to local or remote destination) some model checks and we don't treat them differently. The fact this was surfaced as a potential problem here is that `SimpleTestCase` was used to avoid database queries and previously the suite of checks performed by default didn't access the database. The thing is even if Django passes `databases=None` or doesn't call tests tagged with `Tag.database` it cannot guarantee that the check it calls actually don't access the database, it just happened to be the case within Django core for a long time.
     7Another way to see it is that `staticfiles` checks could perform access control gated I/O to determine if they are properly setup (e.g. has access to local or remote destination) like model checks do against the database and we don't treat them differently.
     8
     9The fact this was surfaced as a potential problem here is that `SimpleTestCase` was used to avoid database queries and previously the suite of checks performed by default didn't access the database. The thing is even if Django passes `databases=None` or doesn't call tests tagged with `Tag.database` it cannot guarantee that the check it calls actually don't access the database, it just happened to be the case within Django core for a long time.
    810
    911For these reasons I ''think'' we should keep things as they are but in all cases I would likely augment the release notes to describe better that this is expected and running `check` without `--tag database` might require database access from now on.
Back to Top