Opened 3 weeks ago

Last modified 3 weeks ago

#36724 closed Bug

FilteredSelectMultiple widget has broken "for" attribute on <legend> — at Version 5

Reported by: Jacob Walls Owned by: Varun Kasyap Pentamaraju
Component: Forms Version: 6.0
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Jacob Walls)

  • View the User model in the admin
  • Inspect the label "Groups:" 
    <legend for="id_groups">Groups:</legend>
  • Query for that element: 
    > document.getElementById("id_groups")
null

There should probably be an id on the top <div> in this structure?

<div>
  <div class="flex-container">
    <div class="related-widget-wrapper" data-model-ref="group">
      <div class="selector">
        <div class="selector-available">
          <div id="id_groups_from_title" class="selector-available-title">
     ...

SelectFilter2.js constructs ids like "id_groups_from_title" and "id_groups_selector_chosen" in this case.

Change History (5)

comment:1 by Antoliny, 3 weeks ago

Triage Stage: Unreviewed → Accepted

Thank you !

It might be better for the legend tag to be associated with the "from" box.

Last edited 3 weeks ago by Antoliny (previous) (diff)

comment:2 by Varun Kasyap Pentamaraju, 3 weeks ago

Owner: set to Varun Kasyap Pentamaraju
Status: new → assigned

Willing to contribute

comment:3 by Varun Kasyap Pentamaraju, 3 weeks ago

Has patch: set

​https://github.com/django/django/pull/20080

comment:4 by Jacob Walls, 3 weeks ago

Needs tests: set

comment:5 by Jacob Walls, 3 weeks ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.
Back to Top