Changes between Initial Version and Version 1 of Ticket #36663, comment 8


Ignore:
Timestamp:
Nov 8, 2025, 1:50:32 PM (41 hours ago)
Author:
Simon Charette

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #36663, comment 8

    initial v1  
    11You might have noticed it during the review Tim but the proposed patch happens to achieve exactly what you're after.
    22
    3 Since the implicit exclusion of `Tags.databases` [https://github.com/django/django/commit/0b83c8cc4db95812f1e15ca19d78614e94cf38dd#diff-f10ce154e1f5bcdba92b54ebf8cb57357b404a3f03ab51ca85a031358f7372ecL66-L69 is no longer applied] all checks (including the `Tags.databases` ones) are now performed on all management commands unless `--database` is specified.
     3Since the implicit exclusion of `Tags.databases` [https://github.com/django/django/commit/0b83c8cc4db95812f1e15ca19d78614e94cf38dd#diff-f10ce154e1f5bcdba92b54ebf8cb57357b404a3f03ab51ca85a031358f7372ecL66-L69 is no longer applied] all checks (including the `Tags.databases` ones) are now performed on all management commands unless `--database` is specified (on commands that support it like `migrate` and `check`).
    44
    5 A problem I see with this approach is that since system checks are performed by management commands by default (unless they are marked with `requires_system_checks = False`) it means that users who might be interested achieving the previous behaviour cannot and must use `--skip-checks` to disable all of them. This is fine by me but I wanted to flag it for reviewers as I'll adjust the documentation accordingly.
     5A problem I see with this approach is that since system checks are performed by management commands by default (unless they are marked with `requires_system_checks = False`) it means that users who might be interested in achieving the previous behaviour cannot and must use `--skip-checks` to disable all of them. This is fine by me as it's aligned with the thinking that no checks are more special than others but I wanted to flag it for reviewers as I'll adjust the documentation accordingly.
Back to Top