Opened 14 months ago

Last modified 3 weeks ago

#36523 closed Cleanup/optimization

Implement helper method to find module path of value — at Initial Version

Reported by: Jake Howard Owned by:
Component: Utilities Version: dev
Severity: Normal Keywords:
Cc: Jake Howard Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Finding the module path for where a given class or function is defined is functionality used in a few places across the Django codebase. Whilst in the majority of cases, f"{val.__module__}.{val.__qualname__}" is enough, there are some cases it's not.

As part of #35859, a few more cases of this pattern are being added to the codebase. I think we're now at the [point https://en.wikipedia.org/wiki/Rule_of_three_(computer_programming)] where it makes sense to extract this out to a helper function somewhere in django.utils. The implementation in django.migrations.serializer.TypeSerializer seems to be the most robust, however will want some more thorough testing based on different input types.

Change History (0)

Note: See TracTickets for help on using tickets.
Back to Top