Changes between Version 1 and Version 2 of Ticket #36430


Ignore:
Timestamp:
Jun 2, 2025, 4:55:22 PM (3 months ago)
Author:
Jacob Walls
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #36430 – Description

    v1 v2  
    55When the list of fields exceeds 1, we go through the `elif` branch and arrive at much higher limits. I'm pretty sure this shows that the limit of 500 for `fields=["pk"]` is overly protective and can just be removed.
    66
    7 I don't have a unit test to provide, but you can play with changing the limit from 500 to 501 and see that `test_large_delete` still passes (no trouble selecting 501 objects). (You can also adjust `test_max_batch_size()` to provide a s
     7I don't have a unit test to provide, but you can play with changing the limit from 500 to 501 and see that `test_large_delete` still passes (no trouble selecting 501 objects).
    88
    99(I found this while trying to [https://github.com/django/django/pull/19502#discussion_r2118612666 refactor] a different call site away from `max_query_params` in the hopes of just calling `bulk_batch_size()` until I saw how overly protective it was.)
Back to Top