Opened 5 weeks ago

Last modified 2 weeks ago

#36142 assigned Cleanup/optimization

django.shortcuts.get_object_or_404 does not support translation for error messages (i18n) — at Initial Version

Reported by: Abror Izzatullaev Owned by:
Component: Internationalization Version: 5.2
Severity: Normal Keywords: i18 Internationalization
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no
Pull Requests:How to create a pull request

Description 

class WheatProvidingViewSet(viewsets.ModelViewSet):
    queryset = WheatProviding.objects.all()
    serializer_class = WheatProvidingSerializer

    def destroy(self, request, *args, **kwargs):
        instance = self.get_object()

The code above demonstrates a Django REST Framework (DRF) ModelViewSet. When a non-existent ID is provided, the destroy method raises a 404 Not Found error. However, the error message is not translated.

The root cause of this issue is that ModelViewSet relies on Django’s get_object_or_404 function, which does not support internationalization (i18n) for its error messages.

Could you consider adding support for translations in the get_object_or_404 function? This enhancement would allow DRF to natively support localized error messages, improving its usability in multilingual applications.

According to the ticket's flags, the next step(s) to move this issue forward are:

  • To provide a patch by sending a pull request. Claim the ticket when you start working so that someone else doesn't duplicate effort. Before sending a pull request, review your work against the patch review checklist. Check the "Has patch" flag on the ticket after sending a pull request and include a link to the pull request in the ticket comment when making that update. The usual format is: [https://github.com/django/django/pull/#### PR].

Change History (0)

Note: See TracTickets for help on using tickets.
Back to Top