Opened 11 months ago
Last modified 10 months ago
#35998 closed Cleanup/optimization
Add caching to urlize — at Initial Version
| Reported by: | Sarah Boyce | Owned by: | |
|---|---|---|---|
| Component: | Template system | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
urlize will checks every word for whether it is a url (and then updates the url to be a html link)
We can add some form of caching so that it doesn't repeat the checks on the same "word"
PR: https://github.com/django/django/pull/18665
Benchmarks:
Before:
>>> import cProfile
>>> from django.template.defaultfilters import urlize
>>> cProfile.run("urlize('Django. ' * 1_000)")
61048 function calls (59047 primitive calls) in 0.030 seconds
After:
>>> import cProfile
>>> from django.template.defaultfilters import urlize
>>> cProfile.run("urlize('Django. ' * 1_000)")
3783 function calls (3702 primitive calls) in 0.005 seconds
PR to add benchmark to django-asv: https://github.com/django/django-asv/pull/91
Note:
See TracTickets
for help on using tickets.