Changes between Version 1 and Version 2 of Ticket #35836, comment 2


Ignore:
Timestamp:
Oct 13, 2024, 9:51:08 PM (2 months ago)
Author:
Simon Charette

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #35836, comment 2

    v1 v2  
    33In other words, if you extend undocumented and unstable part of the framework you must be prepared to adapt your code and provide a solution that goes beyond bisecting the origin of the problem you are experiencing.
    44
    5 In the case of 14c8504a37afad96ab93cf82f47b13bcc4d00621 I think it's a sane change in towards extensibility and something we'd want to keep in `main`. `SQLQuery.get_compiler` is by no means meant to be used as a hook to augment the where clause of a `QuerySet`, this should be done at the manager level.
     5In the case of 14c8504a37afad96ab93cf82f47b13bcc4d00621 I think it's a sane change in towards extensibility and something we'd want to keep in `main`. `SQLQuery.get_compiler` is by no means meant to be used as a hook to augment the where clause of a `QuerySet` like you did; this should be done at the manager level or at the queryset level at worst.
    66
    77At this point, even if we were to land a solution that you'd have to provide and build a rationale for it wouldn't make it to a public release until 5.2 which is meant to be released in April 2025. If your solution runs into problems when dealing with subqueries and you want to double down on this approach you should be able to identify the proper attributes to used specialized logic.
Back to Top