Changes between Initial Version and Version 1 of Ticket #35769


Ignore:
Timestamp:
Sep 17, 2024, 1:14:12 AM (3 months ago)
Author:
Richard Laager
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #35769

    • Property Has patch set
  • Ticket #35769 – Description

    initial v1  
    83831. When there are multiple fields in a row, there are issues in both the tablet and mobile screen sizes. First off, there are two instances of a selector that's supposed to match, but doesn't because of the changed structure. If we fix that to match the new structure, then that fixes the phone size class. See phone-before1.png, phone-before2.png, phone-after1.png, and phone-after2.png. The "1" images are manually grabbed/cropped and show a single-line field above it, which is good for comparing to the working single-line example. The "2" images are of that particular DOM node via the Google Chrome Inspector's feature to screenshot just a given node, so those are easier to directly compare.
    8484
    85 2. With that first issue fixed, the tablet view still isn't correct. In Django 3.2, moving to the tablet view forced one-field-per-line whether that was necessary (width-wise) or not. If I take the same approach here, by setting "width: 100%" on that `<div>`, then I get the same behavior and it looks good. Compare tablet-mid2.png (which has the fixed selectors, but no `width: 100%`) to tablet-after2.png (which has both).
     852. With that first issue fixed, the tablet view still isn't correct. In Django 3.2, moving to the tablet view forced one-field-per-line whether that was necessary (width-wise) or not. If I take the same approach here, by setting `width: 100%` on that `<div>`, then I get the same behavior and it looks good. Compare tablet-mid2.png (which has the fixed selectors, but no `width: 100%`) to tablet-after2.png (which has both).
    8686
    8787**The Patch**
Back to Top