| 1 | | Hi everyone, |
| 2 | | |
| 3 | | I’m new to contributing to Django and noticed this issue reported by Jon Ribbens regarding the GeoIP2Exception in the django.contrib.gis.geoip2 module. I understand that the current implementation does not align with the documentation, as GeoIP2Exception is not handling exceptions from the geoip2 library as described. |
| 4 | | |
| 5 | | I’m interested in collaborating on this issue and would like to contribute a solution. My goal is to address the discrepancy between the documentation and the implementation. Here are a few thoughts on how we might approach it: |
| 6 | | |
| 7 | | |
| 8 | | {{{ |
| 9 | | Update the Code: Modify the GeoIP2 class to catch exceptions from the geoip2 library and re-raise them as GeoIP2Exception, aligning with the documentation. This might impact backward compatibility. |
| 10 | | |
| 11 | | Introduce a New Exception: Create a new exception class, GeoIP2UnderlyingException, which wraps geoip2.errors.GeoIP2Error. This would preserve backward compatibility while providing a clear way to handle underlying exceptions. |
| 12 | | |
| 13 | | }}} |
| 14 | | |
| 15 | | I’m open to suggestions and feedback on these approaches or any other ideas you might have. If possible, I would like to take ownership of this ticket and work on a solution. |
| 16 | | |
| 17 | | Please let me know if there are any additional considerations or if you would prefer a specific approach. |