Opened 7 months ago
Last modified 3 months ago
#35650 assigned New feature
Multi select checkboxes with shift key is not working in TabularInlineAdmin and StackedInlineAdmin — at Version 6
| Reported by: | tanaydin sirin | Owned by: | tanaydin sirin |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | yes |
| Pull Requests: | 18438 build:success, | ||
Description (last modified by ) ¶
On any object list, we can select multiple objects by pressing the shift key while clicking the second checkbox, but it's not possible with TabularInline and StackedInlineAdmin ModelAdmin.
According to the ticket's flags, the next step(s) to move this issue forward are:
- To improve the patch as described in the pull request review comments or on this ticket, then uncheck "Patch needs improvement".
If creating a new pull request, include a link to the pull request in the ticket comment when making that update. The usual format is:
[https://github.com/django/django/pull/#### PR].
Change History (6)
follow-up: 5 comment:3 by , 7 months ago
| Patch needs improvement: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
| Version: | 5.1 → dev |
Hello tanaydin sirin, thank you for your interest in making Django better. I have reproduced the described issue, and I agree it would be good to allow for shift-selecting in tabular admins just like in the changelist page.
I took a quite look at your PR, and I was thinking that instead of providing new javascript, we should try to re-use/generalize what the changelist page is already using. Could you look into that?
comment:4 by , 7 months ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
comment:5 by , 6 months ago
Hello Natalia Bidart, I've made the changes. Shall I do anything else about ticket?
Replying to Natalia Bidart:
Hello tanaydin sirin, thank you for your interest in making Django better. I have reproduced the described issue, and I agree it would be good to allow for shift-selecting in tabular admins just like in the changelist page.
I took a quite look at your PR, and I was thinking that instead of providing new javascript, we should try to re-use/generalize what the changelist page is already using. Could you look into that?
comment:6 by , 6 months ago
| Description: | modified (diff) |
|---|---|
| Summary: | Multi select checkboxes with shift key is not working in TabularInlineAdmin → Multi select checkboxes with shift key is not working in TabularInlineAdmin and StackedInlineAdmin |
https://github.com/django/django/pull/18438