Opened 4 months ago
Last modified 45 hours ago
#35650 assigned New feature
Multi select checkboxes with shift key is not working in TabularInlineAdmin — at Version 11
Reported by: | tanaydin sirin | Owned by: | tanaydin sirin |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | yes |
Description (last modified by )
On any object list, we can select multiple objects by pressing the shift key while clicking the second checkbox, but it's not possible with TabularInline ModelAdmin.
(Same situation applies to StackedInlineAdmin too, I think it's better to fix it in another commit)
Change History (11)
follow-up: 5 comment:3 by , 4 months ago
Patch needs improvement: | set |
---|---|
Triage Stage: | Unreviewed → Accepted |
Version: | 5.1 → dev |
Hello tanaydin sirin, thank you for your interest in making Django better. I have reproduced the described issue, and I agree it would be good to allow for shift-selecting in tabular admins just like in the changelist page.
I took a quite look at your PR, and I was thinking that instead of providing new javascript, we should try to re-use/generalize what the changelist page is already using. Could you look into that?
comment:4 by , 4 months ago
Owner: | set to |
---|---|
Status: | new → assigned |
comment:5 by , 3 months ago
Hello Natalia Bidart, I've made the changes. Shall I do anything else about ticket?
Replying to Natalia Bidart:
Hello tanaydin sirin, thank you for your interest in making Django better. I have reproduced the described issue, and I agree it would be good to allow for shift-selecting in tabular admins just like in the changelist page.
I took a quite look at your PR, and I was thinking that instead of providing new javascript, we should try to re-use/generalize what the changelist page is already using. Could you look into that?
comment:6 by , 3 months ago
Description: | modified (diff) |
---|---|
Summary: | Multi select checkboxes with shift key is not working in TabularInlineAdmin → Multi select checkboxes with shift key is not working in TabularInlineAdmin and StackedInlineAdmin |
comment:7 by , 3 months ago
Thank you tanaydin sirin! The expected ticket update process is described in these docs. Basically you need to uncheck the "patch needs improvement" flag, and then this ticket will show up in the "needs review queue" in the Django Development Dashboard.
comment:8 by , 3 months ago
Patch needs improvement: | unset |
---|
comment:9 by , 3 months ago
Needs tests: | set |
---|---|
Patch needs improvement: | set |
comment:10 by , 3 days ago
Needs tests: | unset |
---|---|
Patch needs improvement: | unset |
UI/UX: | set |
comment:11 by , 2 days ago
Description: | modified (diff) |
---|---|
Summary: | Multi select checkboxes with shift key is not working in TabularInlineAdmin and StackedInlineAdmin → Multi select checkboxes with shift key is not working in TabularInlineAdmin |
https://github.com/django/django/pull/18438