Opened 8 months ago
Last modified 8 months ago
#35338 closed Bug
Behaviour change in URL patterns. — at Initial Version
Reported by: | Carlton Gibson | Owned by: | nobody |
---|---|---|---|
Component: | Core (URLs) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Adam Johnson | Triage Stage: | Unreviewed |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
There's a behaviour change on main
pre-5.1 in 5dfcf343cd414d3f7a33dabb763b4478fa081d72 for #35250.
commit 5dfcf343cd414d3f7a33dabb763b4478fa081d72 Author: Adam Johnson <me@adamj.eu> Date: Sat Feb 24 19:14:22 2024 +0000 Refs #35250 -- Avoided double conversion in RoutePattern. django/urls/resolvers.py | 58 ++++++++++++++++++++++++++++++------------------ 1 file changed, 36 insertions(+), 22 deletions(-)
Since this commit, there are two failures in the Channels test suite.
$ pytest -k test_routing.py ... =========================== short test summary info ============================ FAILED tests/test_routing.py::test_url_router_nesting_path - ValueError: No r... FAILED tests/test_routing.py::test_path_remaining - ValueError: No route foun... ================== 2 failed, 6 passed, 55 deselected in 0.07s ==================
See CI run here: https://github.com/django/channels/actions/runs/8467612542/job/23198786518#step:5:342
Note:
See TracTickets
for help on using tickets.