Opened 6 months ago
Last modified 6 months ago
#35329 closed Bug
Bug UniqueConstraint with condition and nulls-distinct — at Version 1
Reported by: | Lucas Lemke | Owned by: | nobody |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | 5.0 |
Severity: | Release blocker | Keywords: | nulls-distinct, condition, UniqueConstraint |
Cc: | Lucas Lemke, Simon Charette | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
Hi, I`m Lucas (https://github.com/lsaunitti)
I found a bug when set a UniqueConstrain using condition using nulls_distinct using like that:
Screenshot 2024-03-25 at 10.47.59.png
When django generate SQL to create a check constraint the result is ... WHERE <condition> NULLS NOT DISTINCT
.
It raise an exception on Postgresql.
To fix it, I suggest change the file django/db/backends/base/schema.py on line 132:
Today:
sql_create_unique_index = ( "CREATE UNIQUE INDEX %(name)s ON %(table)s " "(%(columns)s)%(include)s%(condition)s%(nulls_distinct)s" )
To:
sql_create_unique_index = ( "CREATE UNIQUE INDEX %(name)s ON %(table)s " "(%(columns)s)%(include)s%(nulls_distinct)s%(condition)s" )
Regards,
Lucas Lemke Saunitti
Software Engineer
Change History (1)
comment:1 by , 6 months ago
Cc: | added |
---|---|
Component: | Error reporting → Database layer (models, ORM) |
Description: | modified (diff) |
Keywords: | UniqueConstraint added; UniqueConstrain removed |
Owner: | set to |
Severity: | Normal → Release blocker |
Triage Stage: | Unreviewed → Accepted |
Note:
See TracTickets
for help on using tickets.
Thank you for your report Lucas!
Marking as a release blocker since
nulls_distinct
is a new feature introduced in Django 5.0.The Postgres docs clearly point that
NULLS DISTINCT
should come beforeWHERE
, sorry for missing that.Would you be interested in submitting a PR with the proposed changes? Adding a test should be as simple as taking inspiration from the ones introduced when the feature was added.