Changes between Initial Version and Version 1 of Ticket #35316, comment 2


Ignore:
Timestamp:
Mar 18, 2024, 6:23:26 PM (9 months ago)
Author:
Manolis Stamatogiannakis

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #35316, comment 2

    initial v1  
    2525Also, a quick GH search shows a number of repositories modifying `used_parameters` [2]. So, although not thorougly documented, this is not something super-exotic for users customizing admin filters, and one would expect that there will be more codebases that will have to implement similar workarounds.
    2626
    27 Overall, the sparse documentation for BooleanFieldListFilter/FieldListFilter should not be a reason for breakage, when that is easily avoidable.
     27Overall, IMHO, the sparse documentation for BooleanFieldListFilter/FieldListFilter should not be a reason for breakage, when that is easily avoidable.
    2828
    29 Along this line, I think that updating `build_q_object_from_lookup_parameters()` as proposed in PR #17990 will be a useful addition, as long as there are no side-effects that I missed and would outweigh the benefits.
     29Along this line, I believe that updating `build_q_object_from_lookup_parameters()` as proposed in PR-17990 will be a useful addition, as long as there are no side-effects that I missed and would outweigh the benefits. And as far as the test suite goes, it appears there aren't.
    3030
    3131
Back to Top