Context Navigation

Changes between Initial Version and Version 1 of Ticket #35154

Timestamp:: Jan 30, 2024, 1:38:39 AM (10 months ago)
Author:: Mariusz Felisiak
Comment:: Why was __contains__ not added in the first place?

Have you read the discussion that you mention in the ticket? or comments in #24141? The entire discussion is about __contains__ and there was a consensus to add contains() instead.

Ticket #35154
- Property Resolution → wontfix
- Property Status new → closed
- Property Type Uncategorized → New feature

initial	v1
5	5	results in python using the fallback solution: https://docs.python.org/3/reference/expressions.html#membership-test-details
6	6	Because https://groups.google.com/g/django-developers/c/NZaMq9BALrs/m/OCNTh6QyCAAJ deiced to implement contains in https://code.djangoproject.com/ticket/24141
7		I think it is only consistent to have the same behavior implemented in __contains__. I would expect that, it is also a more efficient implementation and unifies django behavior. Nevertheless, documentation is needed why this inconsistency exists. I was not able to find a reason. Because the mailing list agreed on adding contains, this is discussed behavior. Why was __contains__ not added in the first place? To not have breaking changes? I cannot see what would break.
	7	I think it is only consistent to have the same behavior implemented in `__contains__`. I would expect that, it is also a more efficient implementation and unifies django behavior. Nevertheless, documentation is needed why this inconsistency exists. I was not able to find a reason. Because the mailing list agreed on adding contains, this is discussed behavior. Why was `__contains__` not added in the first place? To not have breaking changes? I cannot see what would break.
8	8
9	9	As said in https://code.djangoproject.com/ticket/31561 a queryset could be a collection to make typing easier. But this is not the intention of this issue.