Changes between Initial Version and Version 1 of Ticket #34840, comment 19


Ignore:
Timestamp:
Sep 19, 2023, 6:00:20 PM (8 months ago)
Author:
Simon Charette

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #34840, comment 19

    initial v1  
    55I think it makes sense to use this approach in cases where Python input poses type ambiguity at the database level like it did with the `IN` operator, after all we were forced to add `::text` cast because Postgres doesn't know what the type of `%s IS NULL` should be.
    66
    7 In all cases the adjustments to `Q.check` to handle `EmptyResultSet` should be added as other lookups could generate it, the same can be said with `FullResultSet`.
     7In all cases the adjustments to `Q.check` to handle `EmptyResultSet` should be added as other lookups could generate it, the same can be said about `FullResultSet`.
    88
    99I think we should not let the discussion about the silencing of `DatabaseError` die off though and consider a deprecation path to raise the awareness of the issue. Maybe a possible alternative solution that doesn't warrant expression introspection (e.g. special casing `RawSQL`) could be a `Constraint` kwarg that allows disabling model level validation entirely? That could be a way to silence the warning during the deprecation period.
Back to Top