#34759 closed Cleanup/optimization (fixed)
Confirm/Add support for SpatiaLite 5.1
Reported by: | Olivier Tabone | Owned by: | Pieter Cardillo Kwok |
---|---|---|---|
Component: | GIS | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Pieter Cardillo Kwok | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description
SpatiaLite is preparing to release 5.1.
This ticket would fix broken test cases and update the documentation about this new version.
with 5.1.0 RC1:
FAIL: test_asgml (gis_tests.geoapp.test_functions.GISFunctionsTests.test_asgml)
Change History (17)
comment:1 by , 15 months ago
Triage Stage: | Unreviewed → Accepted |
---|---|
Type: | Uncategorized → Cleanup/optimization |
comment:2 by , 15 months ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
I would like to take responsibility for resolving this ticket and contributing to the Django project. I have reviewed the ticket description and test_asgml function, and I believe I can effectively address the issue or implement the requested feature in one or two weeks. I am a backend developer for Django, and this seems to be first good issue to start with.
Regards,
Aman Gora
comment:3 by , 15 months ago
Owner: | changed from | to
---|
Aman, thanks for picking this ticket, however, as far as I'm aware, Olivier is already working on this.
comment:4 by , 15 months ago
Easy pickings: | set |
---|---|
Owner: | changed from | to
Hi Aman, Mariusz,
I'm not working on it right now. I reported the issue and did not assign it to myself. Aman can give a try on it.
- Regards
comment:5 by , 15 months ago
Spatialite 5.1.0 is out :
- https://www.gaia-gis.it/fossil/libspatialite/index
- https://groups.google.com/g/spatialite-users/c/LjEKIv0rfrQ
still same test failure
comment:6 by , 13 months ago
Cc: | added |
---|
comment:7 by , 13 months ago
If some of you want to test Spatialite 5.1 in a GNU/Linux system, it is already available as a system package in Ubuntu 23.10 (to be released in October) and Debian Testing.
comment:8 by , 13 months ago
Hello, I'm currently investigating this ticket since there has been no update in the past 8 weeks. I'm also trying to reach out to Aman Gora to ask whether he's still working on this ticket or not. Is it okay for me to assume ownership of the ticket if there is no response from Aman until next week?
comment:9 by , 13 months ago
Owner: | changed from | to
---|
comment:10 by , 13 months ago
Hello folks I was able to replicate the error by updating spatialite to 5.1.0 and using django docker box. So I'd like to take ownership of the ticket and start debugging the error. I'll provide some updates periodically here and I'm also active in Django discord forum. Please feel free to reach out through discord if needed (my discord name: @peter. tag: ,# 5816 ).
comment:11 by , 13 months ago
Hello, I'd like to give update on the progress.
It's available in branch 'ticket_34759' on django repo in my GitHub Profile:
https://github.com/PieterCK/django/tree/ticket_34759
and a mini documentation / note about the problem, solution, dev env and setup here:
https://docs.google.com/document/d/1MKw2OnhmoWP4h00tCo85oziGBv1g747RxaBIaYwmctc/edit?usp=sharing
I've added a test case for test_asgml
function. now there are 2 cases for valid GML strings that the function may output. The reason for why the new output is valid and can be found in the documentation above.
comment:12 by , 13 months ago
Has patch: | set |
---|
comment:13 by , 13 months ago
Needs documentation: | set |
---|
comment:14 by , 13 months ago
Needs documentation: | unset |
---|---|
Triage Stage: | Accepted → Ready for checkin |
Tentatively accepted, hopefully there will be nothing to fix for the final 5.1 release.